Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MariaDB September Releases #15

Merged
merged 1 commit into from
Sep 15, 2024
Merged

MariaDB September Releases #15

merged 1 commit into from
Sep 15, 2024

Conversation

jwaisner
Copy link
Contributor

@jwaisner jwaisner commented Sep 13, 2024 •
edited by qodo-merge-pro bot
Loading

PR Type

enhancement

Description

  • Added configuration files for new MariaDB versions: 10.5.26, 10.6.19, 10.11.9, 11.1.6, 11.2.5, 11.4.3, 11.5.2, and 11.6.1-RC.
  • Updated my.ini and backup my.ini.ber files for each new version with server and client settings.
  • Updated releases.properties with new MariaDB versions and corresponding download URLs.
  • Changed bundle.release date in build.properties to 2024.9.13.

Changes walkthrough 📝

Relevant files
Configuration changes
26 files
bearsampp.conf
Add configuration for MariaDB 10.11.9                                       

bin/mariadb10.11.9/bearsampp.conf

  • Added configuration for MariaDB version 10.11.9.
  • Set default port to 3307.
  • Included executable paths and root credentials.
    		•  +10/-0   
    my.ini
    Add my.ini for MariaDB 10.11.9                                                     

    bin/mariadb10.11.9/my.ini

  • Added my.ini configuration for MariaDB 10.11.9.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 10.11.9                                       

    bin/mariadb10.11.9/my.ini.ber

  • Added backup my.ini configuration for MariaDB 10.11.9.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 10.5.26                                       

    bin/mariadb10.5.26/bearsampp.conf

  • Added configuration for MariaDB version 10.5.26.
  • Set default port to 3307.
  • Included executable paths and root credentials.
    		•  +10/-0   
    my.ini
    Add my.ini for MariaDB 10.5.26                                                     

    bin/mariadb10.5.26/my.ini

  • Added my.ini configuration for MariaDB 10.5.26.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 10.5.26                                       

    bin/mariadb10.5.26/my.ini.ber

  • Added backup my.ini configuration for MariaDB 10.5.26.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 10.6.19                                       

    bin/mariadb10.6.19/bearsampp.conf

  • Added configuration for MariaDB version 10.6.19.
  • Set default port to 3307.
  • Included executable paths and root credentials.
    		•  +10/-0   
    my.ini
    Add my.ini for MariaDB 10.6.19                                                     

    bin/mariadb10.6.19/my.ini

  • Added my.ini configuration for MariaDB 10.6.19.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 10.6.19                                       

    bin/mariadb10.6.19/my.ini.ber

  • Added backup my.ini configuration for MariaDB 10.6.19.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 11.1.6                                         

    bin/mariadb11.1.6/bearsampp.conf

  • Added configuration for MariaDB version 11.1.6.
  • Set default port to 3307.
  • Included executable paths and root credentials.
    		•  +10/-0   
    my.ini
    Add my.ini for MariaDB 11.1.6                                                       

    bin/mariadb11.1.6/my.ini

  • Added my.ini configuration for MariaDB 11.1.6.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 11.1.6                                         

    bin/mariadb11.1.6/my.ini.ber

  • Added backup my.ini configuration for MariaDB 11.1.6.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 11.2.5                                         

    bin/mariadb11.2.5/bearsampp.conf

  • Added configuration for MariaDB version 11.2.5.
  • Set default port to 3307.
  • Included executable paths and root credentials.
    		•  +10/-0   
    my.ini
    Add my.ini for MariaDB 11.2.5                                                       

    bin/mariadb11.2.5/my.ini

  • Added my.ini configuration for MariaDB 11.2.5.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 11.2.5                                         

    bin/mariadb11.2.5/my.ini.ber

  • Added backup my.ini configuration for MariaDB 11.2.5.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 11.4.3                                         

    bin/mariadb11.4.3/bearsampp.conf

  • Added configuration for MariaDB version 11.4.3.
  • Set default port to 3307.
  • Included executable paths and root credentials.
    		•  +10/-0   
    my.ini
    Add my.ini for MariaDB 11.4.3                                                       

    bin/mariadb11.4.3/my.ini

  • Added my.ini configuration for MariaDB 11.4.3.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 11.4.3                                         

    bin/mariadb11.4.3/my.ini.ber

  • Added backup my.ini configuration for MariaDB 11.4.3.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 11.5.2                                         

    bin/mariadb11.5.2/bearsampp.conf

  • Added configuration for MariaDB version 11.5.2.
  • Set default port to 3307.
  • Included executable paths and root credentials.
    		•  +10/-0   
    my.ini
    Add my.ini for MariaDB 11.5.2                                                       

    bin/mariadb11.5.2/my.ini

  • Added my.ini configuration for MariaDB 11.5.2.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 11.5.2                                         

    bin/mariadb11.5.2/my.ini.ber

  • Added backup my.ini configuration for MariaDB 11.5.2.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 11.6.1-RC                                   

    bin/mariadb11.6.1-RC/bearsampp.conf

  • Added configuration for MariaDB version 11.6.1-RC.
  • Set default port to 3307.
  • Included executable paths and root credentials.
    		•  +10/-0   
    my.ini
    Add my.ini for MariaDB 11.6.1-RC                                                 

    bin/mariadb11.6.1-RC/my.ini

  • Added my.ini configuration for MariaDB 11.6.1-RC.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 11.6.1-RC                                   

    bin/mariadb11.6.1-RC/my.ini.ber

  • Added backup my.ini configuration for MariaDB 11.6.1-RC.
  • Configured server and client settings.
  • Set buffer sizes and paths.
    		•  +46/-0   
    build.properties
    Update bundle release date                                                             

    build.properties

    • Updated bundle.release date to 2024.9.13.
    		 +1/-1     
    releases.properties
    Add new MariaDB versions to releases                                         

    releases.properties

  • Added new MariaDB versions to the release list.
  • Updated URLs for new releases.
    		•  +8/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @jwaisner
    Adding new MariaDB release versions and updating configuration files
    dd07240 
    - Added new MariaDB versions to `releases.properties` (10.5.26, 10.6.19, 10.11.9, 11.1.6, 11.2.5, 11.4.3, 11.5.2, 11.6.1-RC)
- Created configuration files for the new MariaDB versions
- Updated `bundle.release` date in `build.properties` to 2024.9.13
    @jwaisner jwaisner requested a review from N6REJ as a code owner September 13, 2024 23:20
    @jwaisner jwaisner added the enhancement ✨ Improve program label Sep 13, 2024
    @qodo-merge-pro Qodo Merge Pro
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Incorrect Path
    The basedir and datadir paths in the backup configuration file for MariaDB 10.5.26 are incorrect. They point to version 11.4.2 instead of 10.5.26.

    @qodo-merge-pro Qodo Merge Pro
    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Correct the MariaDB version in configuration paths

    Update the basedir and datadir paths to use the correct MariaDB version (10.5.26)
    instead of 11.4.2.

    bin/mariadb10.5.26/my.ini.ber [17-19]

    -basedir=~BEARSAMPP_LIN_PATH~/bin/mariadb/mariadb11.4.2
+basedir=~BEARSAMPP_LIN_PATH~/bin/mariadb/mariadb10.5.26
 log-error=~BEARSAMPP_LIN_PATH~/logs/mariadb.log
-datadir=~BEARSAMPP_LIN_PATH~/bin/mariadb/mariadb11.4.2/data
+datadir=~BEARSAMPP_LIN_PATH~/bin/mariadb/mariadb10.5.26/data
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion correctly identifies and fixes a critical error in the configuration paths, ensuring they match the intended MariaDB version, which is crucial for proper functionality.

    		9
    Enhancement
    Improve readability by grouping MariaDB versions

    Consider adding a comment or separator to group MariaDB versions by major release
    number for better readability and maintenance.

    releases.properties [10-12]

    +# MariaDB 10.5.x
 10.5.26 = https://github.com/Bearsampp/module-mariadb/releases/download/2024.9.13/bearsampp-mariadb-10.5.26-2024.9.13.7z
+
+# MariaDB 10.6.x
 10.6.8 = https://github.com/Bearsampp/module-mariadb/releases/download/2022.05.21/bearsampp-mariadb-10.6.8-2022.05.21.7z
 10.6.9 = https://github.com/Bearsampp/module-mariadb/releases/download/2022.09.04/bearsampp-mariadb-10.6.9-2022.09.04.7z
    • Apply this suggestion
    Suggestion importance[1-10]: 6

    Why: The suggestion enhances code readability and maintainability by organizing versions logically, but it does not address any functional issues, making it a minor improvement.

    		6

    @N6REJ N6REJ merged commit 7a91e75 into main Sep 15, 2024
    1 check passed
    @N6REJ N6REJ deleted the September branch September 15, 2024 18:38
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @N6REJ N6REJ Awaiting requested review from N6REJ N6REJ is a code owner

    Assignees
    No one assigned
    Labels
    enhancement ✨ Improve program enhancement Review effort [1-5]: 2
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @jwaisner @N6REJ